JsValue::to_json fix integer property keys
#4011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4011 +/- ##
==========================================
+ Coverage 47.24% 52.79% +5.54%
==========================================
Files 476 480 +4
Lines 46892 46684 -208
==========================================
+ Hits 22154 24645 +2491
+ Misses 24738 22039 -2699 ☔ View full report in Codecov by Sentry. |
CrazyboyQCD
reviewed
Sep 29, 2024
Comment on lines
147
to
151
| .and_then(|x| x.value().cloned()) | ||
| { | ||
| Some(val) => val.to_json(context), | ||
| None => Ok(Value::Null), | ||
| }; |
There was a problem hiding this comment.
Maybe a bit off, but we could avoid the clone here with extra map:
.and_then(|x| x.value().map(|v| v.to_json(context)))
{
Some(val) => val?,
None => Value::Null,
};And similar thing can be done here
There was a problem hiding this comment.
In the worst case it's still just cloning of a smart pointer so I don't think that it has much overhead costs, but ok, done
HalidOdat
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes #3923